Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 Fixes #2810. Pressing Alt key on a Toplevel with only a MenuBar throws System.InvalidOperationException. #2812

Closed
wants to merge 7 commits into from
Closed

v2 Fixes #2810. Pressing Alt key on a Toplevel with only a MenuBar throws System.InvalidOperationException. #2812

wants to merge 7 commits into from

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 15, 2023

Fixes #2810 - The Enter and Leave events work now with the correct sequence on toplevels.

For v2.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner August 15, 2023 17:43
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 31, 2023

Closing this because is a duplicate of the #2846.

@BDisp BDisp closed this Aug 31, 2023
@BDisp BDisp deleted the v2_alt-key-on-window-with-menubar-fix_2776 branch October 2, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig Awaiting requested review from tig tig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BDisp